Skip to content

Don't use needsUpdate for quick tasks #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't use needsUpdate for quick tasks #28

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Sep 28, 2022 •
edited
Loading

needsUpdate may be wrong when the branch changes; these ones are now so
fast thanks to being pure JS that we can just always run their contents
and be sure that the outputs are right.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks (this PR)
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 884c29f to 9cfb18f Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 56ef0e1 to e9316dd Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 9cfb18f to 0405877 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from e9316dd to 1c70182 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 0405877 to d804da9 Compare October 4, 2022 17:59
@jakebailey jakebailey changed the title Clean up some TODOs Remove ref files from testRunner Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 1c70182 to 25cb26a Compare October 4, 2022 17:59
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from d804da9 to dc0dcaa Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Remove ref files from testRunner Convert __require back to require for external bundlers Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 25cb26a to 96f3991 Compare October 4, 2022 19:06
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from dc0dcaa to 5dd52e5 Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 96f3991 to 9576473 Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 5dd52e5 to 41f5a32 Compare October 4, 2022 21:02
@jakebailey jakebailey changed the title Convert __require back to require for external bundlers Add ts to globalThis for convenience during debugging Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 9576473 to 4849168 Compare October 4, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 41f5a32 to 704dac1 Compare October 4, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 4849168 to 12bafe1 Compare October 4, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch 4 times, most recently from b71e8b2 to f3bd118 Compare October 6, 2022 18:35
@jakebailey jakebailey changed the title Add ts to globalThis for convenience during debugging Add a --bundle=false variant to CI Oct 6, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 12bafe1 to 7094ca0 Compare October 6, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from f3bd118 to f03a0e5 Compare October 7, 2022 18:34
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 7094ca0 to 2349bc4 Compare October 7, 2022 18:35
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from f03a0e5 to 697b552 Compare October 7, 2022 19:04
@jakebailey jakebailey changed the title Add a --bundle=false variant to CI Temporarily disable template literals Oct 7, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 2349bc4 to f5ed806 Compare October 7, 2022 19:04
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 697b552 to ed4feed Compare October 7, 2022 19:31
@jakebailey jakebailey changed the title Temporarily disable template literals Pull LKG script change from other branch Oct 7, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from de72845 to e4ef938 Compare October 24, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 06fd201 to 2dd50e5 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from e4ef938 to 6276686 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 2dd50e5 to 1c5adef Compare October 27, 2022 04:26
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 6276686 to fe66643 Compare October 27, 2022 04:27
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 1c5adef to f228ffc Compare October 27, 2022 17:44
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from fe66643 to 8a4e51a Compare October 27, 2022 17:45
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from f228ffc to fd3428a Compare October 28, 2022 02:26
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 8a4e51a to 2f79f18 Compare October 28, 2022 02:27
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from fd3428a to 01839d2 Compare October 31, 2022 21:37
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 2f79f18 to 7cc1ad4 Compare October 31, 2022 21:38
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 01839d2 to 294e719 Compare November 2, 2022 00:48
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 7cc1ad4 to 0eba132 Compare November 2, 2022 00:48
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 294e719 to 8ad35b2 Compare November 2, 2022 16:59
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 0eba132 to 5c8524a Compare November 2, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 8ad35b2 to 7618a69 Compare November 2, 2022 19:50
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 5c8524a to 9297909 Compare November 2, 2022 19:50
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 7618a69 to c7d69f5 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 9297909 to 3efc360 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from c7d69f5 to 0c12baa Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 3efc360 to 92c84be Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 0c12baa to 37eeaba Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 92c84be to 14b7504 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 37eeaba to 6a92bb1 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 14b7504 to 552c800 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-25 branch from 6a92bb1 to 958c796 Compare November 7, 2022 21:38
@jakebailey
Don't use needsUpdate for quick tasks
14e5186 
needsUpdate may be wrong when the branch changes; these ones are now so
fast thanks to being pure JS that we can just always run their contents
and be sure that the outputs are right.
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 552c800 to 14e5186 Compare November 7, 2022 21:38
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-26 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey